xuanchi/XCEngine
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove scene view orbit roll

Browse Source
This commit is contained in:
ssdfasd
2026-03-28 18:02:09 +08:00
parent 001e45bf6b
commit da486075e1
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
editor/src/Viewport/SceneViewportCameraController.h
View File

@@ -2,6 +2,7 @@
#include <XCEngine/Components/TransformComponent.h> #include <XCEngine/Components/TransformComponent.h>
#include <XCEngine/Core/Math/Math.h> #include <XCEngine/Core/Math/Math.h>
#include <XCEngine/Core/Math/Quaternion.h>
#include <XCEngine/Core/Math/Vector3.h> #include <XCEngine/Core/Math/Vector3.h>
#include <algorithm> #include <algorithm>
@@ -94,7 +95,10 @@ public:
void ApplyTo(Components::TransformComponent& transform) const { void ApplyTo(Components::TransformComponent& transform) const {
transform.SetPosition(GetPosition()); transform.SetPosition(GetPosition());
transform.LookAt(m_focalPoint); transform.SetRotation(Math::Quaternion::FromEulerAngles(
-m_pitchDegrees * Math::DEG_TO_RAD,
m_yawDegrees * Math::DEG_TO_RAD,
0.0f));
} }
private: private:

7
tests/editor/test_scene_viewport_camera_controller.cpp
View File

@@ -34,8 +34,11 @@ TEST(SceneViewportCameraController_Test, ApplyToMatchesComputedPositionAndForwar
controller.ApplyTo(*cameraObject.GetTransform()); controller.ApplyTo(*cameraObject.GetTransform());
EXPECT_TRUE(NearlyEqual(cameraObject.GetTransform()->GetPosition(), controller.GetPosition())); EXPECT_TRUE(NearlyEqual(cameraObject.GetTransform()->GetPosition(), controller.GetPosition()));
const Vector3 localFocus = cameraObject.GetTransform()->InverseTransformPoint(controller.GetFocalPoint()); EXPECT_TRUE(NearlyEqual(
EXPECT_GT(localFocus.z, 0.0f); cameraObject.GetTransform()->GetForward().Normalized(),
controller.GetForward(),
1e-3f));
EXPECT_GT(Vector3::Dot(cameraObject.GetTransform()->GetUp().Normalized(), Vector3::Up()), 0.0f);
} }
TEST(SceneViewportCameraController_Test, ApplyInputUpdatesOrbitPanAndZoomState) { TEST(SceneViewportCameraController_Test, ApplyInputUpdatesOrbitPanAndZoomState) {