refactor(srp): move renderer feature setup into renderer data
Introduce a formal ScriptableRendererData setup seam so renderer feature attachment is owned by renderer data instead of renderer constructors pulling feature caches. Route lifecycle and reuse probes through the new setup path, lock the non-public setup seam in the API surface probe, and update scripting expectations accordingly.
This commit is contained in:
@@ -1178,6 +1178,7 @@ TEST_F(
|
||||
bool hasRendererBackedRenderPipelineAssetType = false;
|
||||
bool hasRendererBackedRenderPipelineType = false;
|
||||
bool hasRendererDrivenRenderPipelineType = false;
|
||||
bool hasRendererDataSetupRenderer = false;
|
||||
bool hasRendererSupportsRendererRecording = false;
|
||||
bool hasRendererRecordRenderer = false;
|
||||
bool hasPublicRendererSupportsStageRenderGraph = false;
|
||||
@@ -1287,6 +1288,10 @@ TEST_F(
|
||||
selectionScript,
|
||||
"HasRendererDrivenRenderPipelineType",
|
||||
hasRendererDrivenRenderPipelineType));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
selectionScript,
|
||||
"HasRendererDataSetupRenderer",
|
||||
hasRendererDataSetupRenderer));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
selectionScript,
|
||||
"HasRendererSupportsRendererRecording",
|
||||
@@ -1330,6 +1335,7 @@ TEST_F(
|
||||
EXPECT_TRUE(hasRendererBackedRenderPipelineAssetType);
|
||||
EXPECT_TRUE(hasRendererBackedRenderPipelineType);
|
||||
EXPECT_TRUE(hasRendererDrivenRenderPipelineType);
|
||||
EXPECT_TRUE(hasRendererDataSetupRenderer);
|
||||
EXPECT_TRUE(hasRendererSupportsRendererRecording);
|
||||
EXPECT_TRUE(hasRendererRecordRenderer);
|
||||
EXPECT_FALSE(hasPublicRendererSupportsStageRenderGraph);
|
||||
@@ -2561,6 +2567,7 @@ TEST_F(
|
||||
|
||||
int observedCreatePipelineCallCount = 0;
|
||||
int observedCreateRendererCallCount = 0;
|
||||
int observedSetupRendererCallCount = 0;
|
||||
int observedCreateFeatureCallCount = 0;
|
||||
int observedReleaseRendererDataRuntimeResourcesCallCount = 0;
|
||||
int observedDisposePipelineCallCount = 0;
|
||||
@@ -2575,6 +2582,10 @@ TEST_F(
|
||||
script,
|
||||
"ObservedCreateRendererCallCount",
|
||||
observedCreateRendererCallCount));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedSetupRendererCallCount",
|
||||
observedSetupRendererCallCount));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedCreateFeatureCallCount",
|
||||
@@ -2602,6 +2613,7 @@ TEST_F(
|
||||
|
||||
EXPECT_EQ(observedCreatePipelineCallCount, 1);
|
||||
EXPECT_EQ(observedCreateRendererCallCount, 0);
|
||||
EXPECT_EQ(observedSetupRendererCallCount, 0);
|
||||
EXPECT_EQ(observedCreateFeatureCallCount, 0);
|
||||
EXPECT_EQ(observedReleaseRendererDataRuntimeResourcesCallCount, 0);
|
||||
EXPECT_EQ(observedDisposePipelineCallCount, 1);
|
||||
@@ -2684,6 +2696,7 @@ TEST_F(
|
||||
|
||||
int observedCreatePipelineCallCount = 0;
|
||||
int observedCreateRendererCallCount = 0;
|
||||
int observedSetupRendererCallCount = 0;
|
||||
int observedCreateFeatureCallCount = 0;
|
||||
int observedReleaseRendererDataRuntimeResourcesCallCount = 0;
|
||||
int observedDisposePipelineCallCount = 0;
|
||||
@@ -2698,6 +2711,10 @@ TEST_F(
|
||||
script,
|
||||
"ObservedCreateRendererCallCount",
|
||||
observedCreateRendererCallCount));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedSetupRendererCallCount",
|
||||
observedSetupRendererCallCount));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedCreateFeatureCallCount",
|
||||
@@ -2725,6 +2742,7 @@ TEST_F(
|
||||
|
||||
EXPECT_EQ(observedCreatePipelineCallCount, 2);
|
||||
EXPECT_EQ(observedCreateRendererCallCount, 2);
|
||||
EXPECT_EQ(observedSetupRendererCallCount, 2);
|
||||
EXPECT_EQ(observedCreateFeatureCallCount, 2);
|
||||
EXPECT_EQ(observedReleaseRendererDataRuntimeResourcesCallCount, 2);
|
||||
EXPECT_EQ(observedDisposePipelineCallCount, 0);
|
||||
@@ -2795,6 +2813,7 @@ TEST_F(
|
||||
|
||||
int observedCreatePipelineCallCount = 0;
|
||||
int observedCreateRendererCallCount = 0;
|
||||
int observedSetupRendererCallCount = 0;
|
||||
int observedCreateFeatureCallCount = 0;
|
||||
int observedReleaseRendererDataRuntimeResourcesCallCount = 0;
|
||||
int observedDisposePipelineCallCount = 0;
|
||||
@@ -2809,6 +2828,10 @@ TEST_F(
|
||||
script,
|
||||
"ObservedCreateRendererCallCount",
|
||||
observedCreateRendererCallCount));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedSetupRendererCallCount",
|
||||
observedSetupRendererCallCount));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedCreateFeatureCallCount",
|
||||
@@ -2836,6 +2859,7 @@ TEST_F(
|
||||
|
||||
EXPECT_EQ(observedCreatePipelineCallCount, 0);
|
||||
EXPECT_EQ(observedCreateRendererCallCount, 0);
|
||||
EXPECT_EQ(observedSetupRendererCallCount, 0);
|
||||
EXPECT_EQ(observedCreateFeatureCallCount, 2);
|
||||
EXPECT_EQ(observedReleaseRendererDataRuntimeResourcesCallCount, 2);
|
||||
EXPECT_EQ(observedDisposePipelineCallCount, 0);
|
||||
@@ -3103,11 +3127,17 @@ TEST_F(
|
||||
engine->OnUpdate(0.016f);
|
||||
|
||||
int observedCreateRendererCallCount = 0;
|
||||
int observedSetupRendererCallCount = 0;
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedCreateRendererCallCount",
|
||||
observedCreateRendererCallCount));
|
||||
EXPECT_TRUE(runtime->TryGetFieldValue(
|
||||
script,
|
||||
"ObservedSetupRendererCallCount",
|
||||
observedSetupRendererCallCount));
|
||||
EXPECT_EQ(observedCreateRendererCallCount, 1);
|
||||
EXPECT_EQ(observedSetupRendererCallCount, 1);
|
||||
|
||||
firstRecorder->Shutdown();
|
||||
secondRecorder->Shutdown();
|
||||
|
||||
Reference in New Issue
Block a user