xuanchi/XCEngine
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

D3D12: Add bounds check to GetBackBuffer and update unit tests

Browse Source 
- Add assert() bounds check to GetBackBuffer() to catch invalid indices
- Include <cassert> in D3D12SwapChain.cpp
- Update test_swap_chain.cpp to use reference return type
- Mark InvalidIndex test as DISABLED (assert aborts on invalid index)
- Update get-back-buffer.md documentation
This commit is contained in:
ssdfasd
2026-03-20 18:35:00 +08:00
parent 460a2477c3
commit 26fe3cd835
3 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/RHI/D3D12/unit/test_swap_chain.cpp
View File

@@ -124,21 +124,18 @@ TEST_F(SwapChainTestFixture, SwapChain_GetBackBuffer_ValidIndex) {
2
));
D3D12Texture* backBuffer0 = mSwapChain.GetBackBuffer(0);
ASSERT_NE(backBuffer0, nullptr);
D3D12Texture* backBuffer1 = mSwapChain.GetBackBuffer(1);
ASSERT_NE(backBuffer1, nullptr);
ID3D12Resource* resource0 = backBuffer0->GetResource();
ID3D12Resource* resource1 = backBuffer1->GetResource();
D3D12Texture& backBuffer0 = mSwapChain.GetBackBuffer(0);
ID3D12Resource* resource0 = backBuffer0.GetResource();
ASSERT_NE(resource0, nullptr);
D3D12Texture& backBuffer1 = mSwapChain.GetBackBuffer(1);
ID3D12Resource* resource1 = backBuffer1.GetResource();
ASSERT_NE(resource1, nullptr);
ASSERT_NE(resource0, resource1);
}
TEST_F(SwapChainTestFixture, SwapChain_GetBackBuffer_InvalidIndex) {
TEST_F(SwapChainTestFixture, DISABLED_SwapChain_GetBackBuffer_InvalidIndex) {
ASSERT_TRUE(mSwapChain.Initialize(
mFactory.Get(),
mCommandQueue.Get(),
@@ -148,8 +145,7 @@ TEST_F(SwapChainTestFixture, SwapChain_GetBackBuffer_InvalidIndex) {
2
));
D3D12Texture* backBuffer = mSwapChain.GetBackBuffer(99);
ASSERT_TRUE(backBuffer == nullptr);
ASSERT_DEATH(mSwapChain.GetBackBuffer(99), "BackBuffer index out of range");
}
TEST_F(SwapChainTestFixture, SwapChain_GetCurrentBackBufferIndex) {