engine: sync editor rendering and ui changes

tests/RHI/OpenGL/unit/test_backend_specific.cpp

@@ -1,6 +1,7 @@
 #include "fixtures/OpenGLTestFixture.h"
 
 #include "XCEngine/RHI/OpenGL/OpenGLDescriptorSet.h"
+#include "XCEngine/RHI/OpenGL/OpenGLPipelineState.h"
 #include "XCEngine/RHI/OpenGL/OpenGLPipelineLayout.h"
 #include "XCEngine/RHI/OpenGL/OpenGLResourceView.h"
 #include "XCEngine/RHI/OpenGL/OpenGLSampler.h"
@@ -21,6 +22,7 @@
 #include <cstring>
 #include <algorithm>
 #include <filesystem>
+#include <iostream>
 #include <vector>
 
 using namespace XCEngine::RHI;
@@ -173,6 +175,128 @@ float4 MainPS(PSInput input) : SV_TARGET {
     delete pipelineState;
 }
 
+TEST_F(OpenGLTestFixture, Device_CreatePipelineState_HlslGraphicsShaders_AssignsCombinedSamplerUniformUnits) {
+    ASSERT_TRUE(GetDevice()->MakeContextCurrent());
+    if (!SupportsOpenGLHlslToolchainForTests()) {
+        GTEST_SKIP() << "glslangValidator.exe or spirv-cross.exe was not found.";
+    }
+
+    static const char* hlslSource = R"(
+Texture2D BaseColorTexture : register(t0);
+SamplerState LinearClampSampler : register(s0);
+Texture2D ShadowMapTexture : register(t1);
+SamplerState ShadowMapSampler : register(s1);
+
+struct VSInput {
+    float4 position : POSITION;
+    float2 texcoord : TEXCOORD0;
+};
+
+struct PSInput {
+    float4 position : SV_POSITION;
+    float2 texcoord : TEXCOORD0;
+};
+
+PSInput MainVS(VSInput input) {
+    PSInput output;
+    output.position = input.position;
+    output.texcoord = input.texcoord;
+    return output;
+}
+
+float4 MainPS(PSInput input) : SV_TARGET {
+    float4 baseColor = BaseColorTexture.Sample(LinearClampSampler, input.texcoord);
+    float shadow = ShadowMapTexture.Sample(ShadowMapSampler, input.texcoord).r;
+    return float4(baseColor.rgb * shadow, baseColor.a);
+}
+)";
+
+    GraphicsPipelineDesc pipelineDesc = {};
+    pipelineDesc.topologyType = static_cast<uint32_t>(PrimitiveTopologyType::Triangle);
+    pipelineDesc.renderTargetFormats[0] = static_cast<uint32_t>(Format::R8G8B8A8_UNorm);
+
+    InputElementDesc position = {};
+    position.semanticName = "POSITION";
+    position.semanticIndex = 0;
+    position.format = static_cast<uint32_t>(Format::R32G32B32A32_Float);
+    position.inputSlot = 0;
+    position.alignedByteOffset = 0;
+    pipelineDesc.inputLayout.elements.push_back(position);
+
+    InputElementDesc texcoord = {};
+    texcoord.semanticName = "TEXCOORD";
+    texcoord.semanticIndex = 0;
+    texcoord.format = static_cast<uint32_t>(Format::R32G32_Float);
+    texcoord.inputSlot = 0;
+    texcoord.alignedByteOffset = sizeof(float) * 4;
+    pipelineDesc.inputLayout.elements.push_back(texcoord);
+
+    pipelineDesc.vertexShader.source.assign(hlslSource, hlslSource + std::strlen(hlslSource));
+    pipelineDesc.vertexShader.sourceLanguage = ShaderLanguage::HLSL;
+    pipelineDesc.vertexShader.entryPoint = L"MainVS";
+    pipelineDesc.vertexShader.profile = L"vs_5_0";
+
+    pipelineDesc.fragmentShader.source.assign(hlslSource, hlslSource + std::strlen(hlslSource));
+    pipelineDesc.fragmentShader.sourceLanguage = ShaderLanguage::HLSL;
+    pipelineDesc.fragmentShader.entryPoint = L"MainPS";
+    pipelineDesc.fragmentShader.profile = L"ps_5_0";
+
+    RHIPipelineState* pipelineState = GetDevice()->CreatePipelineState(pipelineDesc);
+    ASSERT_NE(pipelineState, nullptr);
+
+    const GLuint program = static_cast<OpenGLPipelineState*>(pipelineState)->GetProgram();
+    ASSERT_NE(program, 0u);
+
+    const GLint baseColorLocation =
+        glGetUniformLocation(program, "SPIRV_Cross_CombinedBaseColorTextureLinearClampSampler");
+    const GLint shadowLocation =
+        glGetUniformLocation(program, "SPIRV_Cross_CombinedShadowMapTextureShadowMapSampler");
+    ASSERT_GE(baseColorLocation, 0);
+    ASSERT_GE(shadowLocation, 0);
+
+    GLint baseColorUnit = -1;
+    GLint shadowUnit = -1;
+    glGetUniformiv(program, baseColorLocation, &baseColorUnit);
+    glGetUniformiv(program, shadowLocation, &shadowUnit);
+    GLint activeUniformCount = 0;
+    glGetProgramiv(program, GL_ACTIVE_UNIFORMS, &activeUniformCount);
+    for (GLint uniformIndex = 0; uniformIndex < activeUniformCount; ++uniformIndex) {
+        GLsizei nameLength = 0;
+        GLint arraySize = 0;
+        GLenum type = 0;
+        char nameBuffer[256] = {};
+        glGetActiveUniform(
+            program,
+            static_cast<GLuint>(uniformIndex),
+            static_cast<GLsizei>(sizeof(nameBuffer)),
+            &nameLength,
+            &arraySize,
+            &type,
+            nameBuffer);
+        if (nameLength <= 0) {
+            continue;
+        }
+
+        GLint location = glGetUniformLocation(program, nameBuffer);
+        GLint value = -1;
+        if (location >= 0) {
+            glGetUniformiv(program, location, &value);
+        }
+
+        std::cout << "uniform[" << uniformIndex << "] name=" << nameBuffer
+                  << " location=" << location
+                  << " value=" << value
+                  << " type=" << type
+                  << " arraySize=" << arraySize
+                  << std::endl;
+    }
+    EXPECT_EQ(baseColorUnit, 0);
+    EXPECT_EQ(shadowUnit, 1);
+
+    pipelineState->Shutdown();
+    delete pipelineState;
+}
+
 TEST_F(OpenGLTestFixture, CommandList_SetRenderTargets_BindsColorAndDepthAttachments) {
     TextureDesc colorDesc = {};
     colorDesc.width = 128;