refactor(srp): remove native directional shadow planning policy seam

engine/src/Scripting/Mono/MonoScriptRuntime.cpp

@@ -133,7 +133,6 @@ struct ManagedCameraRenderRequestContextState {
     size_t renderedRequestCount = 0u;
     Rendering::DirectionalShadowPlanningSettings
         directionalShadowPlanningSettings = {};
-    bool directionalShadowPlanningSettingsDirty = false;
     bool suppressDirectionalShadow = false;
 };
 
@@ -1505,8 +1504,6 @@ public:
     bool UsesNativeCameraFramePlanBaseline() const override;
     bool UsesNativeCameraFramePlanBaseline(
         int32_t rendererIndex) const override;
-    std::string GetDirectionalShadowPlanningPolicyAssetKey() const
-        override;
     std::string GetCameraFrameStandalonePassAssetKey(
         Rendering::CameraFrameStage stage) const override;
     std::string GetCameraFrameStandalonePassAssetKey(
@@ -1554,8 +1551,6 @@ private:
         MonoObject* assetObject) const;
     MonoMethod* ResolveConfigureDirectionalShadowExecutionStateMethod(
         MonoObject* assetObject) const;
-    MonoMethod* ResolveGetDirectionalShadowPlanningPolicyAssetKeyMethod(
-        MonoObject* assetObject) const;
     MonoMethod* ResolveGetCameraFrameStandalonePassAssetKeyMethod(
         MonoObject* assetObject) const;
     MonoMethod*
@@ -1586,8 +1581,6 @@ private:
         nullptr;
     mutable MonoMethod*
         m_configureDirectionalShadowExecutionStateMethod = nullptr;
-    mutable MonoMethod*
-        m_getDirectionalShadowPlanningPolicyAssetKeyMethod = nullptr;
     mutable MonoMethod* m_getCameraFrameStandalonePassAssetKeyMethod =
         nullptr;
     mutable MonoMethod*
@@ -2006,6 +1999,12 @@ void MonoManagedRenderPipelineAssetRuntime::ConfigureCameraRenderRequest(
     const Rendering::DirectionalShadowPlanningSettings&
         directionalShadowSettings) const {
     if (!EnsureManagedAsset()) {
+        request.directionalShadow = {};
+        Rendering::ApplyDefaultRenderPipelineAssetCameraRenderRequestPolicy(
+            request,
+            renderedBaseCameraCount,
+            renderedRequestCount,
+            directionalShadowSettings);
         return;
     }
 
@@ -2013,6 +2012,12 @@ void MonoManagedRenderPipelineAssetRuntime::ConfigureCameraRenderRequest(
     MonoMethod* const method =
         ResolveConfigureCameraRenderRequestMethod(assetObject);
     if (assetObject == nullptr || method == nullptr) {
+        request.directionalShadow = {};
+        Rendering::ApplyDefaultRenderPipelineAssetCameraRenderRequestPolicy(
+            request,
+            renderedBaseCameraCount,
+            renderedRequestCount,
+            directionalShadowSettings);
         return;
     }
 
@@ -2032,6 +2037,12 @@ void MonoManagedRenderPipelineAssetRuntime::ConfigureCameraRenderRequest(
     if (requestContextObject == nullptr) {
         UnregisterManagedCameraRenderRequestContextState(
             requestContextHandle);
+        request.directionalShadow = {};
+        Rendering::ApplyDefaultRenderPipelineAssetCameraRenderRequestPolicy(
+            request,
+            renderedBaseCameraCount,
+            renderedRequestCount,
+            directionalShadowSettings);
         return;
     }
 
@@ -2041,30 +2052,14 @@ void MonoManagedRenderPipelineAssetRuntime::ConfigureCameraRenderRequest(
         method,
         args,
         nullptr);
-    const std::string directionalShadowPlanningPolicyAssetKey =
-        GetDirectionalShadowPlanningPolicyAssetKey();
+    request.directionalShadow = {};
     if (requestContextState.suppressDirectionalShadow) {
-        request.directionalShadow = {};
-    } else if (requestContextState.directionalShadowPlanningSettingsDirty) {
-        request.directionalShadow = {};
-        if (directionalShadowPlanningPolicyAssetKey.empty()) {
-            Rendering::ApplyDefaultRenderPipelineAssetCameraRenderRequestPolicy(
-                request,
-                renderedBaseCameraCount,
-                renderedRequestCount,
-                requestContextState.directionalShadowPlanningSettings);
-        } else if (!Rendering::Internal::ApplyDirectionalShadowPlanningPolicyByKey(
-                       directionalShadowPlanningPolicyAssetKey,
-                       request,
-                       renderedBaseCameraCount,
-                       renderedRequestCount,
-                       requestContextState.directionalShadowPlanningSettings)) {
-            Debug::Logger::Get().Error(
-                Debug::LogCategory::Rendering,
-                Containers::String(
-                    "MonoManagedRenderPipelineAssetRuntime failed to resolve directional shadow planning policy asset key: ") +
-                    directionalShadowPlanningPolicyAssetKey.c_str());
-        }
+    } else {
+        Rendering::ApplyDefaultRenderPipelineAssetCameraRenderRequestPolicy(
+            request,
+            renderedBaseCameraCount,
+            renderedRequestCount,
+            requestContextState.directionalShadowPlanningSettings);
     }
     UnregisterManagedCameraRenderRequestContextState(
         requestContextHandle);
@@ -2385,37 +2380,6 @@ bool MonoManagedRenderPipelineAssetRuntime::UsesNativeCameraFramePlanBaseline(
            usesBaseline;
 }
 
-std::string MonoManagedRenderPipelineAssetRuntime::
-    GetDirectionalShadowPlanningPolicyAssetKey() const {
-    if (!SyncManagedAssetRuntimeState()) {
-        return {};
-    }
-
-    MonoObject* const assetObject = GetManagedAssetObject();
-    if (assetObject == nullptr) {
-        return {};
-    }
-
-    MonoMethod* const method =
-        ResolveGetDirectionalShadowPlanningPolicyAssetKeyMethod(
-            assetObject);
-    if (method == nullptr) {
-        return {};
-    }
-
-    MonoObject* managedKeyObject = nullptr;
-    if (!m_runtime->InvokeManagedMethod(
-            assetObject,
-            method,
-            nullptr,
-            &managedKeyObject)) {
-        return {};
-    }
-
-    return MonoStringToUtf8(
-        reinterpret_cast<MonoString*>(managedKeyObject));
-}
-
 std::string MonoManagedRenderPipelineAssetRuntime::
     GetCameraFrameStandalonePassAssetKey(
         Rendering::CameraFrameStage stage) const {
@@ -2693,7 +2657,6 @@ void MonoManagedRenderPipelineAssetRuntime::ReleaseManagedAsset() const {
     m_usesNativeCameraFramePlanBaselineContextualMethod = nullptr;
     m_configureRenderSceneSetupMethod = nullptr;
     m_configureDirectionalShadowExecutionStateMethod = nullptr;
-    m_getDirectionalShadowPlanningPolicyAssetKeyMethod = nullptr;
     m_getCameraFrameStandalonePassAssetKeyMethod = nullptr;
     m_getCameraFrameStandalonePassAssetKeyContextualMethod = nullptr;
     m_pipelineRendererAsset.reset();
@@ -2906,22 +2869,6 @@ MonoManagedRenderPipelineAssetRuntime::
     return m_configureDirectionalShadowExecutionStateMethod;
 }
 
-MonoMethod*
-MonoManagedRenderPipelineAssetRuntime::
-    ResolveGetDirectionalShadowPlanningPolicyAssetKeyMethod(
-        MonoObject* assetObject) const {
-    if (m_getDirectionalShadowPlanningPolicyAssetKeyMethod ==
-        nullptr) {
-        m_getDirectionalShadowPlanningPolicyAssetKeyMethod =
-            m_runtime->ResolveManagedMethod(
-                assetObject,
-                "GetDirectionalShadowPlanningPolicyAssetKey",
-                0);
-    }
-
-    return m_getDirectionalShadowPlanningPolicyAssetKeyMethod;
-}
-
 MonoMethod*
 MonoManagedRenderPipelineAssetRuntime::
     ResolveGetCameraFrameStandalonePassAssetKeyMethod(
@@ -5806,7 +5753,6 @@ InternalCall_Rendering_CameraRenderRequestContext_SetDirectionalShadowPlanningSe
     state->directionalShadowPlanningSettings =
         *reinterpret_cast<const Rendering::DirectionalShadowPlanningSettings*>(
             settings);
-    state->directionalShadowPlanningSettingsDirty = true;
 }
 
 void InternalCall_Rendering_CameraRenderRequestContext_ClearDirectionalShadow(